Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): make image_uri optional #1094

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix(server): make image_uri optional #1094

merged 1 commit into from
Dec 10, 2024

Conversation

seriousben
Copy link
Member

Context

Before we got:

indexify.error.ApiException: error deserializing from json bytes, missing field `image_uri` at line 1 column 874, value: "data_model::ComputeGraph"

When running on a previous state store.

What

This PR fixes it by making image_uri an Option.

Testing

Run test_graph_behavior on a previous version of the server and using the same state, run it on the main version.

Contribution Checklist

  • If the python-sdk was changed, please run make fmt in python-sdk/.
  • If the server was changed, please run make fmt in server/.
  • Make sure all PR Checks are passing.

@seriousben seriousben requested a review from j3m7 December 10, 2024 22:04
@stangirala
Copy link
Collaborator

+1

@seriousben seriousben merged commit 535e785 into main Dec 10, 2024
5 checks passed
@seriousben seriousben deleted the seriousben/making-image-uri-optional branch December 10, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j3m7 j3m7 Awaiting requested review from j3m7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seriousben @stangirala