Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): testing releasing building on PRs #1114

Merged
merged 2 commits into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 0 additions & 55 deletions .github/workflows/generate.yml

This file was deleted.

5 changes: 0 additions & 5 deletions .github/workflows/publish_executor_containers.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,6 @@ name: Publish Example Executor Containers
on:
workflow_dispatch:

permissions:
contents: write
actions: write
packages: write

jobs:
build-and-push-docker-images:
name: Build and Push Docker Executor
Expand Down
99 changes: 3 additions & 96 deletions .github/workflows/publish_indexify_server.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,97 +27,8 @@ defaults:
working-directory: ./server

jobs:
build-linux-amd64-package:
name: Build x86_64 Linux Package
runs-on: ubuntu-latest-xlarge
steps:
- uses: actions/checkout@v4
- run: rustup toolchain install nightly --component rustfmt
- run: cargo +nightly fmt --check
- run: cargo install cargo-deb
- run: make build-release
- run: cargo deb --no-build --no-strip --target x86_64-unknown-linux-gnu
- uses: actions/upload-artifact@v4
with:
name: indexify-server-linux-amd64
path: server/target/x86_64-unknown-linux-gnu/release/indexify-server
if-no-files-found: error
- uses: actions/upload-artifact@v4
with:
name: indexify-server-deb-linux-amd64
path: server/target/x86_64-unknown-linux-gnu/debian/indexify-server_*.deb
if-no-files-found: error

build-linux-arm64-package:
name: Build Aarch64 Linux Package
runs-on: ubuntu-latest-xlarge
steps:
- uses: actions/checkout@v4
- run: rustup toolchain install nightly --component rustfmt
- run: cargo +nightly fmt --check
- run: make build-release-aarch64
- run: cargo install cargo-deb
- run: cargo deb --no-build --no-strip --target aarch64-unknown-linux-gnu
- uses: actions/upload-artifact@v4
with:
name: indexify-server-linux-aarch64
path: server/target/aarch64-unknown-linux-gnu/release/indexify-server
if-no-files-found: error
- uses: actions/upload-artifact@v4
with:
name: indexify-server-deb-linux-aarch64
path: server/target/aarch64-unknown-linux-gnu/debian/indexify-server_*.deb
if-no-files-found: error

build-macos-package:
name: Build macOS Package
runs-on: macos-14-xlarge
steps:
- uses: actions/checkout@v4
- run: rustup update
- run: rustup toolchain install nightly --component rustfmt
- run: rustup target add aarch64-apple-darwin
- run: cargo +nightly fmt --check
- run: make package-ui
- run: cargo build --release
- uses: actions/upload-artifact@v4
with:
name: indexify-server-darwin-arm64
path: server/target/release/indexify-server
if-no-files-found: error

# build-macos-package-x86:
# name: Build macOS Package
# runs-on: macos-12
# steps:
# - uses: actions/checkout@v4
# - run: rustup update
# - run: rustup toolchain install nightly --component rustfmt
# - run: cargo +nightly fmt --check
# - run: make package-ui
# - run: cargo build --release
# - uses: actions/upload-artifact@v4
# with:
# name: indexify-server-darwin-amd64
# path: server/target/release/indexify-server
# if-no-files-found: error

# build-windows-package:
# name: Build Windows Package
# runs-on: windows-latest-large
# steps:
# - uses: actions/checkout@v4
# - uses: ilammy/setup-nasm@v1
# - run: rustup toolchain install nightly --component rustfmt
# - run: cargo +nightly fmt --check
# - run: choco install protoc
# - run: make package-ui
# - run: cargo build --release
# - uses: actions/upload-artifact@v4
# with:
# name: indexify-server-windows-amd64.exe
# path: server/target/release/indexify-server.exe
# if-no-files-found: error
build-release-packages:
uses: ./.github/workflows/wf_build_indexify_server_release_packages.yaml

extract-version:
name: Extract Version Number
Expand All @@ -133,11 +44,7 @@ jobs:
name: Create GitHub Release
runs-on: ubuntu-latest
needs:
- build-linux-amd64-package
- build-linux-arm64-package
# - build-windows-package
- build-macos-package
# - build-macos-package-x86
- build-release-packages
- extract-version
steps:
- uses: actions/checkout@v4
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -288,4 +288,9 @@ jobs:
if pgrep -f indexify; then
echo "Error: Some Indexify processes are still running."
exit 1
fi
fi
build_release_packages:
name: Test Building Release Packages
needs: [build_server]
uses: ./.github/workflows/wf_build_indexify_server_release_packages.yaml
103 changes: 103 additions & 0 deletions .github/workflows/wf_build_indexify_server_release_packages.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
name: Build Indexify Server Release Packages

on:
workflow_call:

env:
CARGO_TERM_COLOR: always

defaults:
run:
working-directory: ./server

jobs:
build-linux-amd64-package:
name: Build x86_64 Linux Package
runs-on: ubuntu-latest-xlarge
steps:
- uses: actions/checkout@v4
- run: rustup toolchain install nightly --component rustfmt
- run: cargo +nightly fmt --check
- run: cargo install cargo-deb
- run: make build-release
- run: cargo deb --no-build --no-strip --target x86_64-unknown-linux-gnu
- uses: actions/upload-artifact@v4
with:
name: indexify-server-linux-amd64
path: server/target/x86_64-unknown-linux-gnu/release/indexify-server
if-no-files-found: error
- uses: actions/upload-artifact@v4
with:
name: indexify-server-deb-linux-amd64
path: server/target/x86_64-unknown-linux-gnu/debian/indexify-server_*.deb
if-no-files-found: error

build-linux-arm64-package:
name: Build Aarch64 Linux Package
runs-on: ubuntu-latest-xlarge
steps:
- uses: actions/checkout@v4
- run: rustup toolchain install nightly --component rustfmt
- run: cargo +nightly fmt --check
- run: make build-release-aarch64
- run: cargo install cargo-deb
- run: cargo deb --no-build --no-strip --target aarch64-unknown-linux-gnu
- uses: actions/upload-artifact@v4
with:
name: indexify-server-linux-aarch64
path: server/target/aarch64-unknown-linux-gnu/release/indexify-server
if-no-files-found: error
- uses: actions/upload-artifact@v4
with:
name: indexify-server-deb-linux-aarch64
path: server/target/aarch64-unknown-linux-gnu/debian/indexify-server_*.deb
if-no-files-found: error

build-macos-package:
name: Build macOS Package
runs-on: macos-14-xlarge
steps:
- uses: actions/checkout@v4
- run: rustup update
- run: rustup toolchain install nightly --component rustfmt
- run: rustup target add aarch64-apple-darwin
- run: cargo +nightly fmt --check
- run: make package-ui
- run: cargo build --release
- uses: actions/upload-artifact@v4
with:
name: indexify-server-darwin-arm64
path: server/target/release/indexify-server
if-no-files-found: error

# build-macos-package-x86:
# name: Build macOS Package
# runs-on: macos-12
# steps:
# - uses: actions/checkout@v4
# - run: rustup update
# - run: rustup toolchain install nightly --component rustfmt
# - run: cargo +nightly fmt --check
# - run: make package-ui
# - run: cargo build --release
# - uses: actions/upload-artifact@v4
# with:
# name: indexify-server-darwin-amd64
# path: server/target/release/indexify-server
# if-no-files-found: error

# build-windows-package:
# name: Build Windows Package
# runs-on: windows-latest-large
# steps:
# - uses: actions/checkout@v4
# - uses: ilammy/setup-nasm@v1
# - run: rustup toolchain install nightly --component rustfmt
# - run: cargo +nightly fmt --check
# - run: make package-ui
# - run: cargo build --release
# - uses: actions/upload-artifact@v4
# with:
# name: indexify-server-windows-amd64.exe
# path: server/target/release/indexify-server.exe
# if-no-files-found: error
5 changes: 2 additions & 3 deletions server/Cross.toml
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
[target.aarch64-unknown-linux-gnu]
dockerfile = "dockerfiles/Dockerfile.builder_linux_aarch64"
pre-build = [
"apt-get update && apt-get install --assume-yes build-essential npm curl protobuf-compiler",
"dpkg --add-architecture $CROSS_DEB_ARCH",
"mkdir -p /.npm",
"chown -R 1000:1000 /.npm"
"chown -R 1001:128 /.npm"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some pure magic. Is this Ubuntu specific uid, gid?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like that. For some reason this started breaking for Ubuntu 20 and 22.

That is the part, I can't explain.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

]

[target.x86_64-unknown-linux-gnu]
dockerfile = "dockerfiles/Dockerfile.builder_linux_x86"
pre-build = [
"mkdir -p /.npm",
"chown -R 1000:1000 /.npm"
"chown -R 1001:128 /.npm"
]
25 changes: 11 additions & 14 deletions server/dockerfiles/Dockerfile.builder_linux_aarch64
Original file line number Diff line number Diff line change
@@ -1,22 +1,19 @@
FROM --platform=linux/arm64/v8 python:3.11 AS python
FROM ubuntu:24.04

FROM ubuntu:22.04
ARG DEBIAN_FRONTEND=noninteractive
RUN apt-get update && \
apt-get install --assume-yes --no-install-recommends \
ca-certificates \
build-essential pkg-config clang \
g++-aarch64-linux-gnu libc6-dev-arm64-cross \
git curl

RUN apt-get update && apt-get install --assume-yes --no-install-recommends \
g++-aarch64-linux-gnu \
libc6-dev-arm64-cross git clang
RUN curl -fsSL https://deb.nodesource.com/setup_22.x -o nodesource_setup.sh && \
bash -E nodesource_setup.sh && \
apt-get install --assume-yes --no-install-recommends nodejs

ENV CROSS_TOOLCHAIN_PREFIX=aarch64-linux-gnu-
ENV CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER="$CROSS_TOOLCHAIN_PREFIX"gcc \
AR_aarch64_unknown_linux_gnu="$CROSS_TOOLCHAIN_PREFIX"ar \
CC_aarch64_unknown_linux_gnu="$CROSS_TOOLCHAIN_PREFIX"gcc \
CXX_aarch64_unknown_linux_gnu="$CROSS_TOOLCHAIN_PREFIX"g++ \
RUST_TEST_THREADS=1 \
PKG_CONFIG_PATH="/usr/lib/aarch64-linux-gnu/pkgconfig/:${PKG_CONFIG_PATH}"

RUN apt install -y python3.11 python3.11-dev

COPY --from=python /usr/local/lib/ /opt/sysroot/usr/lib/

ENV RUSTFLAGS="-L /opt/sysroot/usr/lib"
PKG_CONFIG_PATH="/usr/lib/aarch64-linux-gnu/pkgconfig/:${PKG_CONFIG_PATH}"
4 changes: 0 additions & 4 deletions server/dockerfiles/Dockerfile.builder_linux_ubuntu_20.04

This file was deleted.

40 changes: 12 additions & 28 deletions server/dockerfiles/Dockerfile.builder_linux_x86
Original file line number Diff line number Diff line change
@@ -1,28 +1,12 @@
FROM ubuntu:20.04
#LABEL stage=builder

WORKDIR /indexify-build
ENV DEBIAN_FRONTEND=noninteractive

RUN apt-get update
RUN apt -y install software-properties-common unzip \
build-essential make cmake ca-certificates \
curl pkg-config git \
sqlite3 clang gcc-10 g++-10

RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- --default-toolchain stable -y

RUN curl -LO https://github.com/protocolbuffers/protobuf/releases/download/v25.1/protoc-25.1-linux-x86_64.zip

RUN unzip protoc-25.1-linux-x86_64.zip -d /usr/local

ENV PATH="/${HOME}/.cargo/bin:/{HOME}/.local/bin:${PATH}"

ENV CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse

RUN curl -sL https://deb.nodesource.com/setup_22.x | bash

RUN apt install -y nodejs

RUN apt remove -y gcc-9 g++-9
RUN update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-10 20 --slave /usr/bin/g++ g++ /usr/bin/g++-10
FROM ubuntu:24.04

RUN apt-get update && \
apt-get install --assume-yes --no-install-recommends \
ca-certificates \
build-essential pkg-config clang \
g++ \
git curl

RUN curl -fsSL https://deb.nodesource.com/setup_22.x -o nodesource_setup.sh && \
bash -E nodesource_setup.sh && \
apt-get install --assume-yes --no-install-recommends nodejs
Loading