Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail graph update if graph version didn't change #1156

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

eabatalov
Copy link
Contributor

This provides a clear error message to customers showing them that they need to update graph version when deploying an update to it if they manually manage graph versions.

Testing:

make fmt
make test

Contribution Checklist

  • If a Python package was changed, please run make fmt in the package directory.
  • If the server was changed, please run make fmt in server/.
  • Make sure all PR Checks are passing.

This provides a clear error message to customers showing them that
they need to update graph version when deploying an update to it
if they manually manage graph versions.

Testing:

make fmt
make test
@eabatalov eabatalov marked this pull request as ready for review January 13, 2025 17:27
@eabatalov eabatalov merged commit ff64883 into main Jan 13, 2025
8 checks passed
@eabatalov eabatalov deleted the eugene-graph-update-version-error branch January 13, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant