Fix delivering response promises in actor state destructors #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lava
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Looks good in principle, although I think I'm a bit confused by the semantics of when source can or can't be null.
As an aside, I wonder if this comment from response_promise.hpp is also causing races, since the rule doesn't seem to be as clear-cut as the comment suggests:
// Note: response promises must remain local to their owner. Hence, we don't
// need a thread-safe reference count for the state.
dominiklohmann
force-pushed
the
topic/experimental-rp-fix
branch
from
1071976 to
16afd92
Compare
dominiklohmann
force-pushed
the
topic/experimental-rp-fix
branch
from
16afd92 to
bf88d1c
Compare
|
@lava and I went over the changes together in a call to address the review feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.