@ #563 | update window docs #577

datphan · 2018-12-17T10:51:17Z

connect #563

docs/getting_started.rst

datphan · 2018-12-25T03:23:41Z

@hoavt I've applied your comments, pls check again

hoavt · 2018-12-25T07:27:09Z

docs/getting_started.rst


 Manual Installation on Windows
 ------------------------------

+1. Install ``git``:
+
+   Head over to https://git-scm.com/downloads and download their latest release, and follow the install instruction, by then you will have ``Git Bash`` already installed.


installation instruction

hoavt · 2018-12-25T07:27:20Z

docs/getting_started.rst

+
+2. Install ``virtualbox``:
+
+   Head over to https://www.virtualbox.org/ and download their latest release, and follow the install instruction, by then you will have ``virtualbox`` already installed.


installation instruction

hoavt · 2018-12-25T07:27:30Z

docs/getting_started.rst

+
+3. Install ``vagrant``:
+
+   Head over to https://www.vagrantup.com/ and download their latest release, and follow the install instruction, by then you will have ``vagrant`` already installed.


installation instruction

hoavt · 2018-12-25T07:29:12Z

docs/getting_started.rst


 Manual Installation on Windows
 ------------------------------

+1. Install ``git``:


Install Git Bash:

no it is git, Git Bash is included in git

hoavt

@datphan please check my comments.

hoavt · 2018-12-25T07:50:22Z

docs/getting_started.rst


-       ..  code-block:: bash
+download [rsync-3.1](http://www2.futureware.at/~nickoe/msys2-mirror/msys/x86_64/rsync-3.1.2-2-x86_64.pkg.tar.xz) at http://www2.futureware.at/~nickoe/msys2-mirror/msys/x86_64/


Should have the bullet for this section:

Download rsync-3.1 at http://www2.futureware.at/~nickoe/msys2-mirror/msys/x86_64/

Extract and copy rsync.exe to C:\Program Files\Git\usr\bin, then re-open your terminal window.

hoatle

@datphan please check my comments.

hoatle · 2018-12-25T09:14:54Z

docs/getting_started.rst

@@ -147,11 +146,30 @@ Automatic Installation on Windows

 // TODO(hoatle): add this

-.. _manual-installation-on-windows:

 Manual Installation on Windows
 ------------------------------


Please use chocolatey so that users can copy + paste commands to install required packages.

applied, pls check again

hoatle · 2019-01-08T02:27:16Z

assigned to @hoavt to continue reviewing.

new updates

hoavt · 2019-01-09T16:32:47Z

docs/getting_started.rst

-3. Install ``vagrant``:
+   After the installation is finished, restart the machine.
+
+2. Install ``git``:


should mention which versions of git, vagrant, virtualbox are accepted.

hoavt · 2019-01-09T16:38:28Z

docs/getting_started.rst

+
+2. Install ``git``:
+
+   Head over to https://git-scm.com/downloads then follow their installation instruction or use:


I think that instruction to install with the command below is enough for users.

hoavt · 2019-01-09T16:38:48Z

docs/getting_started.rst

+
+2. Install ``git``:
+
+   Head over to https://git-scm.com/downloads then follow their installation instruction or use:


Remove this line

hoavt

@datphan please check my comments.

datphan · 2019-01-15T03:03:13Z

@hoavt applied your comments, pls check again

hoatle

not yet to deprecate the cygwin stuff, we're adding git bash and must use it for a while to see if it's better. Until it's proven, we'll decide to depreciate then.

docs/getting_started.rst

hoatle · 2019-01-15T10:18:31Z

docs/getting_started.rst

+
+- ~~On Windows, you must always use ``Cygwin Terminal``, not ``Git Bash``~~.
+
+- ``Cygwin Terminal`` is now deprecated and no longer support, we are now using ``Git Bash``


not yet deprecated, we're supporting both at the moment. We'll decide to depreciate only when Git Bash is proven to be better and stable.

applied, pls check again, thanks

docs/getting_started.rst

hoatle

@datphan please check my comments.

hoatle

LGTM

ghost assigned datphan Dec 17, 2018

ghost added the stag:under-review label Dec 17, 2018

datphan requested review from hoavt and hoatle and removed request for hoavt December 17, 2018 10:51

hoatle requested review from hoavt, phuonglm and hieptranquoc December 17, 2018 10:52

hoatle assigned hoavt Dec 17, 2018

datphan force-pushed the update_docs branch from 0b84154 to 5a11244 Compare December 17, 2018 10:55

hoavt reviewed Dec 25, 2018

View reviewed changes

docs/getting_started.rst Outdated Show resolved Hide resolved

hoavt reviewed Dec 25, 2018

View reviewed changes

docs/getting_started.rst Outdated Show resolved Hide resolved

datphan force-pushed the update_docs branch 6 times, most recently from d498210 to 66c9475 Compare December 25, 2018 03:22

hoavt reviewed Dec 25, 2018

View reviewed changes

hoavt previously approved these changes Dec 25, 2018

View reviewed changes

hoatle previously requested changes Dec 25, 2018

View reviewed changes

datphan dismissed hoavt’s stale review via 4218a36 January 8, 2019 01:02

datphan force-pushed the update_docs branch from 4218a36 to 5c0af7d Compare January 8, 2019 05:19

hoavt reviewed Jan 9, 2019

View reviewed changes

datphan force-pushed the update_docs branch from 5c0af7d to 9d2bede Compare January 15, 2019 03:02

hoavt previously approved these changes Jan 15, 2019

View reviewed changes

hoatle reviewed Jan 15, 2019

View reviewed changes

hoatle requested changes Jan 15, 2019

View reviewed changes

datphan dismissed hoavt’s stale review via 9b59cd2 January 17, 2019 03:16

datphan force-pushed the update_docs branch 2 times, most recently from bacbdab to 83e1312 Compare January 17, 2019 03:20

@ teracyhq#563 | use rst format

18c130c

datphan force-pushed the update_docs branch from 83e1312 to 18c130c Compare January 17, 2019 03:21

hoatle approved these changes Jan 17, 2019

View reviewed changes

hoatle merged commit 8de30f9 into teracyhq:develop Jan 17, 2019

ghost removed the stag:under-review label Jan 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

@ #563 | update window docs #577

@ #563 | update window docs #577

datphan commented Dec 17, 2018 •

edited by hoatle

Loading

datphan commented Dec 25, 2018

hoavt Dec 25, 2018

datphan Dec 25, 2018

hoavt Dec 25, 2018

datphan Dec 25, 2018

hoavt Dec 25, 2018

datphan Dec 25, 2018

hoavt Dec 25, 2018

datphan Dec 25, 2018

hoavt left a comment

hoavt Dec 25, 2018

datphan Dec 25, 2018

hoatle left a comment

hoatle Dec 25, 2018

datphan Jan 8, 2019

hoatle commented Jan 8, 2019

hoavt Jan 9, 2019

hoavt Jan 9, 2019

hoavt Jan 9, 2019

hoavt left a comment

datphan commented Jan 15, 2019

hoatle left a comment

hoatle Jan 15, 2019

datphan Jan 17, 2019

hoatle left a comment

hoatle left a comment


		2. Install ``virtualbox``:

		Head over to https://www.virtualbox.org/ and download their latest release, and follow the install instruction, by then you will have ``virtualbox`` already installed.


		3. Install ``vagrant``:

		Head over to https://www.vagrantup.com/ and download their latest release, and follow the install instruction, by then you will have ``vagrant`` already installed.


		.. code-block:: bash
		download [rsync-3.1](http://www2.futureware.at/~nickoe/msys2-mirror/msys/x86_64/rsync-3.1.2-2-x86_64.pkg.tar.xz) at http://www2.futureware.at/~nickoe/msys2-mirror/msys/x86_64/


		2. Install ``git``:

		Head over to https://git-scm.com/downloads then follow their installation instruction or use:


		- ~~On Windows, you must always use ``Cygwin Terminal``, not ``Git Bash``~~.

		- ``Cygwin Terminal`` is now deprecated and no longer support, we are now using ``Git Bash``

@ #563 | update window docs #577

@ #563 | update window docs #577

Conversation

datphan commented Dec 17, 2018 • edited by hoatle Loading

datphan commented Dec 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hoavt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hoatle left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hoatle commented Jan 8, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hoavt left a comment

Choose a reason for hiding this comment

datphan commented Jan 15, 2019

hoatle left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hoatle left a comment

Choose a reason for hiding this comment

hoatle left a comment

Choose a reason for hiding this comment

datphan commented Dec 17, 2018 •

edited by hoatle

Loading