Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented ThriftTyped, Encode, and Decode for OrderedFloat<f64> #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ktsujister
Copy link

@ktsujister ktsujister commented Oct 5, 2016

With terminal_thrift 0.3.2, below thrift file:

service Calculator {
    double add(1: double num1, 2: double num2)
}

would generate OrderedFloat<f64> for double.
And since there's no Encode, Decode, and ThriftType implementation for OrderedFloat<f64> you get these errors:

error[E0277]: the trait bound `thrift::rt::OrderedFloat<f64>: thrift::protocol::ThriftTyped` is not satisfied
error[E0277]: the trait bound `thrift::rt::OrderedFloat<f64>: thrift::protocol::Encode` is not satisfied
error[E0277]: the trait bound `thrift::rt::OrderedFloat<f64>: thrift::protocol::Decode` is not satisfied

thrift: master
terminal_thrift: 0.3.2
rust: 1.12.0

…t gets generated for `double` type in thrift config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant