Use Canvas.drawTextRun instead of drawText #2997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnostic-apollo
force-pushed
the
master
branch
from
21804bc
to
3f7a939
Compare
fornwall
force-pushed
the
disable-rtl
branch
from
b0dcdb3
to
ea34268
Compare
drawText does (very) basic BiDi, which causes inconsistent behaviour. This ensures everything is LtR.
fornwall
force-pushed
the
disable-rtl
branch
from
ea34268
to
9ef3e87
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drawText does (very) basic BiDi, which causes inconsistent behaviour. This change ensures everything is LtR.
This fixes #1256 (and somewhat #296).