Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce tf best practices #4

Merged
merged 3 commits into from
Aug 12, 2024
Merged

introduce tf best practices #4

merged 3 commits into from
Aug 12, 2024

Conversation

paliwalvimal
Copy link
Contributor

@paliwalvimal paliwalvimal commented Aug 12, 2024

Prerequisites

  • There is an open issue for the PR that you are making. If not, please open an issue to discuss the change or find an existing issue.

What kind of change does this PR introduce? (check one)

  • Bug fix
  • Feature Request

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Description

implement tf best practices and switch instance_type var to list type from string


Additional context


Fixes #3

@paliwalvimal paliwalvimal self-assigned this Aug 12, 2024
@paliwalvimal paliwalvimal merged commit 4512b54 into main Aug 12, 2024
2 checks passed
@paliwalvimal paliwalvimal deleted the improvements branch August 12, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] instance_type variable should be of type list
1 participant