Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Propagate support for EBS volumes to the root module #223

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

montaguethomas
Copy link

Description

The PR #205 failed to update the main module triggered when using the Terraform Registry as the module source.

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

The PR terraform-aws-modules#205 failed to update the main module triggered when using the Terraform Registry as the module source.
@bryantbiggs
Copy link
Member

this is already included in #217 and will go out on the next major version release since its part of a breaking change

@bryantbiggs bryantbiggs closed this Sep 3, 2024
@montaguethomas
Copy link
Author

@bryantbiggs I'm tracking the wip/v6 branch has the initial implementation. This PR is resolving missing parts and logic of that implementation.

@bryantbiggs bryantbiggs reopened this Sep 3, 2024
@bryantbiggs
Copy link
Member

ah my apologies!

@bryantbiggs bryantbiggs changed the title Add missing support for EBS volumes. fix: Propagate support for EBS volumes to the root module Sep 3, 2024
@bryantbiggs bryantbiggs merged commit 3b09b3a into terraform-aws-modules:wip/v6 Sep 3, 2024
2 of 3 checks passed
@montaguethomas montaguethomas deleted the patch-1 branch September 3, 2024 20:51
Copy link

github-actions bot commented Oct 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants