Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore also network configuration #239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tetienne
Copy link

Description

CodeDeploy also managed the network configuration. See https://docs.aws.amazon.com/codedeploy/latest/userguide/reference-appspec-file-example.html

Motivation and Context

Avoid this kind of error

│ Error: updating ECS Service (arn:aws:ecs:eu-west-1:xxxxx:service/xxxx/xxxx): operation error ECS: UpdateService, https response error StatusCode: 400, RequestID: xxxxxx, InvalidParameterException: Unable to update network parameters on services with a CODE_DEPLOY deployment controller. Use AWS CodeDeploy to trigger a new deployment.
│ 
│   with module.web_service[0].aws_ecs_service.ignore_task_definition[0],
│   on .terraform/modules/web_service/modules/service/main.tf line 219, in resource "aws_ecs_service" "ignore_task_definition":
│  219: resource "aws_ecs_service" "ignore_task_definition" {

Breaking Changes

If some folks use this module with ignore_task_definition_changes set to true but without using CodeDeploy, they won’t be able anymore to update their network configuration.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@tetienne tetienne changed the title Ignore also network configuration fix: ignore also network configuration Oct 31, 2024
@tetienne tetienne changed the title fix: ignore also network configuration fix: Ignore also network configuration Oct 31, 2024
@tetienne
Copy link
Author

@bryantbiggs Any opinion on this PR?

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Dec 15, 2024
@tetienne-zenchef
Copy link

Still relevant.

@github-actions github-actions bot removed the stale label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants