Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change cloudwatch log group output to include all created log groups #19

Conversation

ottramst
Copy link
Contributor

@ottramst ottramst commented Oct 9, 2024

Description

Change the Cloudwatch log group outputs to include all created log groups information

Motivation and Context

When using a configuration such as:

module "elasticache" {
  ...
    log_delivery_configuration = {
    engine-log = {
      destination_type                       = "cloudwatch-logs"
      log_format                             = "json"
      cloudwatch_log_group_retention_in_days = 7
      cloudwatch_log_group_kms_key_id        = module.kms_elasticache_logs.key_arn
    }
  }
  ...
}

the outputs of cloudwatch_log_group_name and cloudwatch_log_group_arn were null

Breaking Changes

None.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@ottramst ottramst changed the title Change cloudwatch log group output to include all created log groups fix: Change cloudwatch log group output to include all created log groups Oct 9, 2024
@ottramst
Copy link
Contributor Author

Can I get a pair of eyes on this please?

@bryantbiggs
Copy link
Member

this is a breaking change - and one we should probably make at some point. however, why is this needed right now?

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Nov 24, 2024
@ottramst
Copy link
Contributor Author

I think it's needed because right now there is no way to get information from the module about operations regarding the Cloudwatch log groups.

If using the configuration provided in the initial message of the pull request, the specified outputs are null

@github-actions github-actions bot removed the stale label Nov 29, 2024
outputs.tf Show resolved Hide resolved
@bryantbiggs bryantbiggs merged commit cdc870e into terraform-aws-modules:master Dec 2, 2024
15 checks passed
antonbabenko pushed a commit that referenced this pull request Dec 2, 2024
## [1.4.1](v1.4.0...v1.4.1) (2024-12-02)

### Bug Fixes

* Change cloudwatch log group output to include all created log groups ([#19](#19)) ([cdc870e](cdc870e))
@antonbabenko
Copy link
Member

This PR is included in version 1.4.1 🎉

Copy link

github-actions bot commented Jan 2, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants