-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Change cloudwatch log group output to include all created log groups #19
fix: Change cloudwatch log group output to include all created log groups #19
Conversation
Can I get a pair of eyes on this please? |
this is a breaking change - and one we should probably make at some point. however, why is this needed right now? |
This PR has been automatically marked as stale because it has been open 30 days |
I think it's needed because right now there is no way to get information from the module about operations regarding the Cloudwatch log groups. If using the configuration provided in the initial message of the pull request, the specified outputs are |
## [1.4.1](v1.4.0...v1.4.1) (2024-12-02) ### Bug Fixes * Change cloudwatch log group output to include all created log groups ([#19](#19)) ([cdc870e](cdc870e))
This PR is included in version 1.4.1 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Change the Cloudwatch log group outputs to include all created log groups information
Motivation and Context
When using a configuration such as:
the outputs of
cloudwatch_log_group_name
andcloudwatch_log_group_arn
were nullBreaking Changes
None.
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request