feat: LogGroup #24
Closed
feat: LogGroup #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
reviewed
Oct 28, 2024
| @@ -26,10 +26,10 @@ resource "aws_elasticache_cluster" "this" { | |||
| ip_discovery = var.ip_discovery | |||
|
|
|||
| dynamic "log_delivery_configuration" { | |||
| for_each = { for k, v in var.log_delivery_configuration : k => v if var.engine != "memcached" && !local.in_replication_group } | |||
There was a problem hiding this comment.
these are not valid changes https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/elasticache_replication_group#log-delivery-configuration - you cannot log for memcached
That doesn't explain anything |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the module enforces cloud watch log group for Redis. Added a variable named "create_cloudwatch_log_group" to provide flexibility of choice to the end user, to leverage or not to leverage via this module.
Motivation and Context
Why is this change required? What problem does it solve?
Enhances flexibility and effective internal usage.
How Has This Been Tested?
Could not use the existing examples as we have our own way of deriving networking information and for other reasons.
Created own/separate example which is not included in the code.
Tested the example code by enabling and disabling "create_cloudwatch_log_group" variable.
Both are working without any issues.
pre-commit run -a is executed successfully before creating PR.