feat: Allow generic assume role conditions #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
antonbabenko
approved these changes
Dec 30, 2024
| @@ -16,6 +16,16 @@ variable "trusted_role_services" { | |||
| default = [] | |||
| } | |||
|
|
|||
| variable "trust_policy_conditions" { | |||
| description = "[Condition constraints](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/iam_policy_document#condition) applied to the trust policy" | |||
| type = list(object({ | |||
There was a problem hiding this comment.
I also think we should start introducing such stricter types for variables where it makes sense. 👍
In my experience with other modules (e.g., S3 bucket), 100% concrete variable types are impossible, which is unfortunate. We need to be careful about that. :)
antonbabenko
pushed a commit
that referenced
this pull request
Dec 30, 2024
## [5.52.0](v5.51.0...v5.52.0) (2024-12-30) ### Features * Allow generic assume role conditions ([#543](#543)) ([c3e54f2](c3e54f2))
|
This PR is included in version 5.52.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request