Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for triggers on docker_registry_image resource #518

Merged
merged 5 commits into from
Jan 12, 2024
Merged

feat: Added support for triggers on docker_registry_image resource #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ec3c67d
fix: support trigger docker registry image
IlyesDemineExtVeolia Nov 29, 2023
fb264ee
fix: support trigger docker registry image
IlyesDemineExtVeolia Nov 30, 2023
69e4565
fix: lint
IlyesDemineExtVeolia Nov 30, 2023
8b7750e
Merge branch 'master' into support-triggers-f-docker-registry-image
IlyesDemineExtVeolia Nov 30, 2023
2f9a8cd
Fixed comparisson with objects/maps
antonbabenko Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: https://github.com/antonbabenko/pre-commit-terraform
rev: v1.83.5
rev: v1.86.0
hooks:
- id: terraform_fmt
- id: terraform_wrapper_module_for_each
Expand Down
4 changes: 1 addition & 3 deletions modules/docker-build/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@ resource "docker_registry_image" "this" {

keep_remotely = var.keep_remotely

triggers = {
image_id = docker_image.this.image_id
}
triggers = length(var.triggers) == 0 ? { image_id = docker_image.this.image_id } : var.triggers
}

resource "aws_ecr_repository" "this" {
Expand Down