-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Added advanced logging configuration. Bump version of AWS provider to 5.32 #531
feat!: Added advanced logging configuration. Bump version of AWS provider to 5.32 #531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please update this module and handle the cases when the user specifies custom log group then default log group should not be created?
Maybe there are other cases that should be considered. I would appreciate if you can think about this and update this PR.
Also, maybe we need to update the log group in the outputs of the module if user specifies custom log group.
My bad, thanks for the review. I've pushed some tweaks that handle the different log group scenarios better.
Existing data source is re-used so outputs should update appropriately. |
logging_config
This PR is included in version 7.0.0 🎉 |
This causes breaks in Gov Cloud see #539 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Adds
logging_config
block for enabling advanced logging.Motivation and Context
Closes #530
Breaking Changes
No
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request