Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Added advanced logging configuration. Bump version of AWS provider to 5.32 #531

Conversation

JoshuaLicense
Copy link
Contributor

Description

Adds logging_config block for enabling advanced logging.

Motivation and Context

Closes #530

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@JoshuaLicense JoshuaLicense changed the title feat: add logging_config feat: Add logging_config Jan 12, 2024
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update this module and handle the cases when the user specifies custom log group then default log group should not be created?

Maybe there are other cases that should be considered. I would appreciate if you can think about this and update this PR.

Also, maybe we need to update the log group in the outputs of the module if user specifies custom log group.

main.tf Outdated Show resolved Hide resolved
@JoshuaLicense
Copy link
Contributor Author

Could you please update this module and handle the cases when the user specifies custom log group then default log group should not be created?

Maybe there are other cases that should be considered. I would appreciate if you can think about this and update this PR.

My bad, thanks for the review. I've pushed some tweaks that handle the different log group scenarios better.

use_existing_cloudwatch_log_group logging_log_group aws_cloudwatch_log_group created
true null ❌ retrieved from data source: "/aws/lambda/${var.lambda_at_edge ? "us-east-1." : ""}${var.function_name}"
true populated ❌ retrieved from data source: var.logging_log_group
false null
false populated ❌ retrieved from data source: var.logging_log_group

Also, maybe we need to update the log group in the outputs of the module if user specifies custom log group.

Existing data source is re-used so outputs should update appropriately.

main.tf Outdated Show resolved Hide resolved
@antonbabenko antonbabenko changed the title feat: Add logging_config feat!: Added advanced logging configuration. Bump version of AWS provider to 5.32 Jan 19, 2024
@antonbabenko antonbabenko merged commit 259b403 into terraform-aws-modules:master Jan 19, 2024
31 checks passed
antonbabenko pushed a commit that referenced this pull request Jan 19, 2024
## [7.0.0](v6.8.0...v7.0.0) (2024-01-19)

### ⚠ BREAKING CHANGES

* Added advanced logging configuration. Bump version of AWS provider to 5.32 (#531)

### Features

* Added advanced logging configuration. Bump version of AWS provider to 5.32 ([#531](#531)) ([259b403](259b403))
@antonbabenko
Copy link
Member

This PR is included in version 7.0.0 🎉

@AndrewCharlesHay
Copy link
Contributor

This causes breaks in Gov Cloud see #539

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
@JoshuaLicense JoshuaLicense deleted the add-advanced-logging-config branch February 29, 2024 09:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add support for logging_config
3 participants