Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AttributeError os.exists is not valid python attribute. #554

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

lociko
Copy link
Contributor

@lociko lociko commented Mar 29, 2024

Description

Fixed an attribute error made by typo

Motivation and Context

This is an error - should be fixed

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@code-intensive
Copy link

code-intensive commented Mar 29, 2024

Several of my CI/CD pipelines have failed as a result of this typo.
The one-liner should be resolved as soon as possible.

Copy link
Contributor

@pdecat pdecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, LGTM !

@pdecat
Copy link
Contributor

pdecat commented Mar 29, 2024

Several of my CI/CD pipelines have failed as a result of this typo. The one-liner should be resolved as soon as possible.

Sorry, I did not notice this issue before as we pin module versions (and then let renovatebot perform the upgrades).

@pdecat
Copy link
Contributor

pdecat commented Mar 29, 2024

Please update the PR title so checks can pass.

@pdecat pdecat self-assigned this Mar 29, 2024
@lociko lociko changed the title Fix AttributeError os.exists is not valid python attribute. fix: AttributeError os.exists is not valid python attribute. Mar 29, 2024
@lociko
Copy link
Contributor Author

lociko commented Mar 29, 2024

Please update the PR title so checks can pass.

Done

@pdecat
Copy link
Contributor

pdecat commented Mar 29, 2024

Hi @antonbabenko, can you merge this? 🙏

Copy link

@code-intensive code-intensive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is clear and straightforward. Could someone with permission to approve kindly provide their approval?

@antonbabenko antonbabenko merged commit 2202912 into terraform-aws-modules:master Mar 29, 2024
29 of 30 checks passed
@pdecat
Copy link
Contributor

pdecat commented Mar 29, 2024

@antonbabenko Too bad, semantic release did not understand the commit message:

[2:02:10 PM] [semantic-release] › ℹ  Start step "analyzeCommits" of plugin "@semantic-release/commit-analyzer"
[2:02:10 PM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  Analyzing commit: Fix AttributeError os.exists is not valid python attribute. (#554)
[2:02:10 PM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  The commit should not trigger a release
[2:02:10 PM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  Analysis of 1 commits complete: no release
[2:02:10 PM] [semantic-release] › ✔  Completed step "analyzeCommits" of plugin "@semantic-release/commit-analyzer"
[2:02:10 PM] [semantic-release] › ℹ  There are no relevant changes, so no new version is released.

https://github.com/terraform-aws-modules/terraform-aws-lambda/actions/runs/8481753919/job/23239717584

@antonbabenko
Copy link
Member

@pdecat could you please make a small PR with any change and good PR title. I will merge it asap. I am traveling/flying and can't do it myself quickly.

@michal-organek
Copy link

I guess commit should have semantic commit convention format fix: AttributeError os.exists is not valid python attribute. instead of Fix AttributeError os.exists is not valid python attribute..

One option is to merge PR using squash with PR summary as commit name.
Second option - add one more PR check like GitHub - wagoid/commitlint-github-action: Lints Pull Request commits with commitlint.

@pdecat
Copy link
Contributor

pdecat commented Mar 29, 2024

@antonbabenko Here we go #555

@antonbabenko
Copy link
Member

This PR is included in version 7.2.5 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants