-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: AttributeError os.exists is not valid python attribute. #554
Conversation
Several of my CI/CD pipelines have failed as a result of this typo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, LGTM !
Sorry, I did not notice this issue before as we pin module versions (and then let renovatebot perform the upgrades). |
Please update the PR title so checks can pass. |
Done |
Hi @antonbabenko, can you merge this? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix is clear and straightforward. Could someone with permission to approve kindly provide their approval?
2202912
into
terraform-aws-modules:master
@antonbabenko Too bad, semantic release did not understand the commit message:
|
@pdecat could you please make a small PR with any change and good PR title. I will merge it asap. I am traveling/flying and can't do it myself quickly. |
I guess commit should have semantic commit convention format One option is to merge PR using squash with PR summary as commit name. |
@antonbabenko Here we go #555 |
This PR is included in version 7.2.5 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Fixed an attribute error made by typo
Motivation and Context
This is an error - should be fixed
Breaking Changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request