-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix package.py commands after :zip not being executed #606
Conversation
sh commands after :zip were not being executed
@antonbabenko , can you please review when you get a chance. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@pdecat what do you think?
## [7.8.1](v7.8.0...v7.8.1) (2024-08-23) ### Bug Fixes * Fix package.py commands after :zip not being executed ([#606](#606)) ([801e69c](801e69c))
This PR is included in version 7.8.1 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
When using the commands option in source_path, commands after ":zip" were not being executed. This PR resolves that unexpected behavior
Motivation and Context
The root cause was that the commands loop read all provided commands, but it didn't add the commands after a ":zip" command to the plan file. This was remediated by adding a check after the commands loop exited to add the remaining commands to the steps.
Breaking Changes
None
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request