Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore current_version changes #35

Conversation

anden-dev
Copy link
Contributor

@anden-dev anden-dev commented Aug 8, 2024

Description

Motivation and Context

Resolves #34

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@anden-dev anden-dev changed the title feat: ignore current_version changes feat: ignore current_version changes Aug 8, 2024
@bryantbiggs
Copy link
Member

we don't ignore computed only values https://github.com/hashicorp/terraform-provider-aws/blob/e22df1a1bbe634a24a1eec4eeed8af3bcc18b3ce/internal/service/kafka/cluster.go#L338-L341 - that wouldn't make sense

This sounds like you are re-exporting the entire output or something else funky

Copy link

github-actions bot commented Sep 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: ignore changes on current_version
2 participants