Skip to content

Commit

Permalink
fix: Ignore tags_all for aws_appautoscaling_target (#431)
Browse files Browse the repository at this point in the history
* fix: added enable_appautoscaling_tags variable

* fix: dynamically set aws_appautoscaling_target tags

* chore: revert variable changes

* fix: set lifecycle ignore_changes on tags_all

* fix: Correct pre-commit checks

---------

Co-authored-by: Bryant Biggs <[email protected]>
  • Loading branch information
busla and bryantbiggs authored Feb 15, 2024
1 parent cf30ef7 commit fa8caad
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: https://github.com/antonbabenko/pre-commit-terraform
rev: v1.83.6
rev: v1.86.0
hooks:
- id: terraform_fmt
- id: terraform_validate
Expand All @@ -27,3 +27,4 @@ repos:
hooks:
- id: check-merge-conflict
- id: end-of-file-fixer
- id: trailing-whitespace
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@ All notable changes to this project will be documented in this file
- Add cluster ARN output as 'this_rds_cluster_arn' ([#48](https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/issues/48))
- Upgraded module to support Terraform 0.12 ([#45](https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/issues/45))

###
###

on ../../modules/aws-rds-aurora/main.tf line 4, in locals:

Expand Down Expand Up @@ -586,7 +586,7 @@ when calling import with this module in the configuration.
- Add cluster ARN output as 'this_rds_cluster_arn' ([#48](https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/issues/48))
- Upgraded module to support Terraform 0.12 ([#45](https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/issues/45))

###
###

on ../../modules/aws-rds-aurora/main.tf line 4, in locals:

Expand Down
6 changes: 6 additions & 0 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,12 @@ resource "aws_appautoscaling_target" "this" {
service_namespace = "rds"

tags = var.tags

lifecycle {
ignore_changes = [
tags_all,
]
}
}

resource "aws_appautoscaling_policy" "this" {
Expand Down

0 comments on commit fa8caad

Please sign in to comment.