Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add RDS cluster activity stream #407

Conversation

magreenbaum
Copy link
Member

@magreenbaum magreenbaum commented Sep 24, 2023

Description

Closes: #404

Motivation and Context

#404

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@bryantbiggs bryantbiggs merged commit 783c686 into terraform-aws-modules:master Oct 9, 2023
12 checks passed
antonbabenko pushed a commit that referenced this pull request Oct 9, 2023
## [8.5.0](v8.4.0...v8.5.0) (2023-10-09)

### Features

* Add RDS cluster activity stream ([#407](#407)) ([783c686](783c686))
@antonbabenko
Copy link
Member

This PR is included in version 8.5.0 🎉

@magreenbaum magreenbaum deleted the feat/db_cluster_activity_stream branch October 9, 2023 13:28
@Z4ck404
Copy link
Contributor

Z4ck404 commented Oct 12, 2023

Thanks a lot @magreenbaum for the great work

################################################################################

resource "aws_rds_cluster_activity_stream" "this" {
count = local.create && var.create_db_cluster_activity_stream ? 1 : 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a limitation on the activity stream as it's not supported by all the instances types.
works only on few of them per this doc : https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/DBActivityStreams.Overview.html

how is that taken into account ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not - that's up to users

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aurora database activity stream support
4 participants