Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support serverlessv2_scaling_configuration.seconds_until_auto_pause #477

Conversation

magreenbaum
Copy link
Member

Description

Support serverlessv2_scaling_configuration.seconds_until_auto_pause.

Motivation and Context

hashicorp/terraform-provider-aws#40441

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit 08dced9 into terraform-aws-modules:master Dec 19, 2024
12 checks passed
antonbabenko pushed a commit that referenced this pull request Dec 19, 2024
## [9.11.0](v9.10.0...v9.11.0) (2024-12-19)

### Features

* Support `serverlessv2_scaling_configuration.seconds_until_auto_pause` ([#477](#477)) ([08dced9](08dced9))
@antonbabenko
Copy link
Member

This PR is included in version 9.11.0 🎉

@magreenbaum magreenbaum deleted the feat/seconds_until_auto_pause branch December 20, 2024 11:39
max_capacity = 10
min_capacity = 0
max_capacity = 10
seconds_until_auto_pause = 3600
Copy link

@schammah schammah Dec 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know this is merge but any reason it was set for 1 hour?
console defaults to 5 mins

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just an example. Real values should be decided by users individually.

Copy link

@schammah schammah Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I understand. I'm using this already, thanks.
I was just reffering what was the default in the console when adding this setting ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants