docs: Fix incorrect condition key in SQS example
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmuscat
changed the title
condition key in SQS examplecondition key in SQS example
bryantbiggs
changed the title
condition key in SQS examplecondition key in SQS example
bryantbiggs
merged commit 501f39c
into
terraform-aws-modules:master
7 of 8 checks passed
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
|
This PR is included in version 6.1.0 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
conditionkey in the SQS example is incorrect and should be replaced with aconditionskey that takes an array of objects (see https://github.com/terraform-aws-modules/terraform-aws-sqs/blob/75e57f71c2c9a2ffb0c17b8e67d7151e345a343f/main.tf#L70).Motivation and Context
When referring to the example, new users to the module will not run into issues.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request