feat!: Refactor count/lists into for_each/maps
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid downtime when adding/removing attachments. With the previous approach, any new or removed attachments would cause the attachment routes to be deleted and re-created according to the new order.
And unifying peering/VPC attachments under one parameter, VPC attachments are filtered out of the parameter to create the VPC attachement resources.
For fetching attachment details. Add VPC attachment accepter resource to avoid the need for "auto-accept shared attachments" when sharing via RAM.
When route destinations are defined
With composite keys to allow associating/propagating custom route tables.
Closed
|
This PR has been automatically marked as stale because it has been open 30 days |
bryantbiggs
changed the title
count/lists into for_each/maps
|
@bryantbiggs anything I can help with to move this along? |
ebarros29
reviewed
Jan 19, 2024
| @@ -162,9 +270,9 @@ resource "aws_ram_resource_association" "this" { | |||
| } | |||
|
|
|||
| resource "aws_ram_principal_association" "this" { | |||
| count = var.create_tgw && var.share_tgw ? length(var.ram_principals) : 0 | |||
| for_each = var.create_tgw && var.share_tgw ? var.ram_principals : [] | |||
There was a problem hiding this comment.
Suggested change
| for_each = var.create_tgw && var.share_tgw ? var.ram_principals : [] | |
| for_each = var.create_tgw && var.share_tgw ? var.ram_principals : toset([]) |
The right side should be a set...
Even fixing it, we will face the for_each problem for computed values as mentioned here by @bryantbiggs
However, the current version of this module is using countwhich will produce the same error for computed values 🤔
3 tasks
|
Could we have a separate PR for adding flow logs? They're quite useful, and it's a shame they're "stuck" in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This module was missing quite a few features that are necessary for true multi-account operation, as well as operational concerns like logging.
Breaking Changes
This PR includes breaking changes due to changes in data structures. The changes to data structures (converting lists/sets to maps, mostly) were necessary to prevent downtime during applies due to deleting/re-creating routes.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestI am running my refactor in production currently, using one AWS account as the hub, and several other AWS accounts as the spokes.