Use python3 for Ubuntu 18.04+ #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johntwyman
approved these changes
Nov 23, 2020
|
Oof. I suddenly realised this PR won't work for RedHat based distros. Anyone care to make a fix? |
|
Should we just leave the RedHat branch of the logic alone for now and update the Ubuntu part? |
|
I made a commit for RedHat based distros not long after that comment. This commit is ready to be merged. We've been using a fork of this repo with this commit in it for almost 2 years now; it works just fine with Ubuntu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current user script doesn't work for Ubuntu LTS > 18.04 due to the fact that python3 is now the default python version. I have confirmed that this PR successfully works with Ubuntu 20.04 LTS.
It won't be backwards compatible though, perhaps someone can suggest a way to do that?