Fix expected expression but found "[" (#12)

* fix expected expression but found "[" * security_groups need to be a list. * Remove extra var * Fix wrong explanation
terraform-community-modules · Jul 27, 2017 · 19f0f52 · 19f0f52
1 parent 3341bd7
commit 19f0f52
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -42,11 +42,11 @@ Usage
 
 ```hcl
 module "ecs-cluster" {
-  source       = "github.com/terraform-community-modules/tf_aws_ecs"
-  cluster_name = "infra-services"
-  servers      = 1
-  subnet_id    = "subnet-6e101446"
-  vpc_id       = "vpc-99e73dfc"
+  source    = "github.com/terraform-community-modules/tf_aws_ecs"
+  name      = "infra-services"
+  servers   = 1
+  subnet_id = "subnet-6e101446"
+  vpc_id    = "vpc-99e73dfc"
 }
 
 ```

diff --git a/main.tf b/main.tf
@@ -29,7 +29,7 @@ resource "aws_launch_configuration" "ecs" {
   instance_type               = "${var.instance_type}"
   key_name                    = "${var.key_name}"
   iam_instance_profile        = "${aws_iam_instance_profile.ecs_profile.name}"
-  security_groups             = "${concat([aws_security_group.ecs.id], var.security_group_ids)}"
+  security_groups             = ["${concat(list(aws_security_group.ecs.id), var.security_group_ids)}"]
   associate_public_ip_address = "${var.associate_public_ip_address}"
 
   ebs_block_device {

diff --git a/templates/user_data.tpl b/templates/user_data.tpl
@@ -3,4 +3,4 @@ echo ECS_CLUSTER=${cluster_name} >> /etc/ecs/ecs.config
 echo 'OPTIONS="$${OPTIONS} --storage-opt dm.basesize=${docker_storage_size}G"' >> /etc/sysconfig/docker
 /etc/init.d/docker restart
 echo ECS_ENGINE_AUTH_TYPE=dockercfg >> /etc/ecs/ecs.config
-echo 'ECS_ENGINE_AUTH_DATA={"https://index.docker.io/v1/": { "auth": "${dockerhub_token}", "email": "${var.dockerhub_email}"}}' >> /etc/ecs/ecs.config
+echo 'ECS_ENGINE_AUTH_DATA={"https://index.docker.io/v1/": { "auth": "${dockerhub_token}", "email": "${dockerhub_email}"}}' >> /etc/ecs/ecs.config