Adding windows support #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm I have some thoughts about this PR, but I'll pop em in issue #31 after I rubber duck a bit with @hakamadare this morning! |
|
Sweet thanks for looking at it! One workaround I have is for the fact that Windows instances have only a single volume (even for the ECS optimized image). So instead of having to figure out a way to switch to using root_block_device I just attach another volume and then in the userdata script mount it and configure docker to use it as the data volume (probably the way it should be imo) |
|
closing this based on the discussion and merge of #31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I'm still struggling with ECS for Windows I was able to use this to stand up a Windows ECS cluster with a second EBS volume and configure docker to use it.
I just created a var for "ecs_platform" and used conditionals to switch the EBS volume path and user_data scripts ( I split them into one for linux and one for Windows).
Let me know what you think.