Skip to content

chore(deps): Add ADC annotations. #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): Add ADC annotations. #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions modules/flex/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,32 @@ spec:
description: Key/Value pairs to be passed to the Dataflow job (as used in the template).
varType: map(string)
defaultValue: {}
connections:
Copy link

@liferoad liferoad Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not redefine these parameters under terraform-google-dataflow. We should be able to directly parse the template metadata json files based on the selected template by the users.

- source:
source: github.com/terraform-google-modules/terraform-google-pubsub
version: ">= 2.0"
spec:
outputExpr: "{\"inputSubscirption\": subscription_paths[0]}"
- source:
source: github.com/terraform-google-modules/terraform-google-pubsub
version: ">= 2.0"
spec:
outputExpr: "{\"inputTopic\": uri}"
- source:
source: github.com/terraform-google-modules/terraform-google-pubsub
version: ">= 2.0"
spec:
outputExpr: "{\"outputTopic\": uri}"
- source:
source: github.com/terraform-google-modules/terraform-google-bigquery
version: ">= 8.0"
spec:
outputExpr: "{\"inputTableSpec\": \"project:bigquery_dataset.table_names[0]\"}"
- source:
source: github.com/terraform-google-modules/terraform-google-bigquery
version: ">= 8.0"
spec:
outputExpr: "{\"outputTableSpec\": \"project:bigquery_dataset.table_names[0]\"}"
- name: labels
description: User labels to be specified for the job.
varType: map(string)
Expand Down
Loading