-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove fuse csi driver from autopilot #2218
base: master
Are you sure you want to change the base?
fix: remove fuse csi driver from autopilot #2218
Conversation
Signed-off-by: drfaust92 <[email protected]>
From the lint test:
|
This can be included in v35.0.1 |
Signed-off-by: drfaust92 <[email protected]>
/gcbrun |
For clarify: "The Cloud Storage FUSE CSI driver is enabled by default for Autopilot clusters." |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @DrFaust92!
Given the removal of the variable for Autopilot clusters, I think we'll want to classify this as a breaking change. Thoughts? Otherwise this LGTM.
apeabody Im fine with as i prefer err on the side of caution. but I dont think its breaking as it not supported toggle anyway |
Agreed - It's an usual edge case as the cluster "behavior" doesn't change, but if present they would need to remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DrFaust92! For caution we'll wait to include a major version, but otherwise LGTM.
Fuse CSI Driver is not supported for autopilot