Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: add deletion_protection to backup module and set it to false in … #670

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

q2w
Copy link
Collaborator

@q2w q2w commented Nov 22, 2024

…intergration tests

This PR also adds wait time to allow propagation of google_project_service_identity throughout the regions.

@q2w q2w force-pushed the update-2211 branch 11 times, most recently from d34ea85 to 18bf00c Compare November 24, 2024 01:31
@q2w q2w marked this pull request as ready for review November 24, 2024 04:11
@q2w q2w requested review from isaurabhuttam, imrannayer and a team as code owners November 24, 2024 04:11
@q2w
Copy link
Collaborator Author

q2w commented Nov 24, 2024

@apeabody @bharathkkb

@bharathkkb bharathkkb changed the title fix: add deletion_protection to backup module and set it to false in … fix!: add deletion_protection to backup module and set it to false in … Nov 25, 2024
@q2w q2w merged commit 5e39538 into terraform-google-modules:master Nov 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants