Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add confidential computing example for intel arch #435

Merged
merged 3 commits into from
Oct 9, 2024
Merged

feat: add confidential computing example for intel arch #435

merged 3 commits into from
Oct 9, 2024

Conversation

arthurlapertosa
Copy link
Contributor

@arthurlapertosa arthurlapertosa commented Sep 26, 2024 •
edited
Loading

add confidential computing example for intel arch

@arthurlapertosa arthurlapertosa marked this pull request as ready for review September 27, 2024 16:46
@arthurlapertosa arthurlapertosa requested a review from a team as a code owner September 27, 2024 16:46
@arthurlapertosa
Copy link
Contributor Author

@apeabody Can you run the build, please?

@apeabody
Copy link
Contributor

/gcbrun

erlanderlo
erlanderlo approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@erlanderlo erlanderlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; thanks for getting this example up to showcase our new integration

test/fixtures/confidential_intel_compute_instance/outputs.tf Outdated Show resolved Hide resolved
@arthurlapertosa
Copy link
Contributor Author

@apeabody could you run the build again? Also, could you please review it whenever possible?

@apeabody
Copy link
Contributor

apeabody commented Oct 8, 2024

/gcbrun

@apeabody
Copy link
Contributor

apeabody commented Oct 8, 2024

/gcbrun

apeabody
apeabody approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @arthurlapertosa!

Reviewed by @erlanderlo

@apeabody apeabody merged commit cf84229 into terraform-google-modules:master Oct 9, 2024
4 checks passed
@release-please release-please bot mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlanderlo erlanderlo erlanderlo approved these changes

@apeabody apeabody apeabody approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arthurlapertosa @apeabody @erlanderlo