Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update permanent test sdnlb secret #1037

Merged
merged 3 commits into from
Sep 17, 2024
Merged

update permanent test sdnlb secret #1037

merged 3 commits into from
Sep 17, 2024

Conversation

Soaib024
Copy link
Member

@Soaib024 Soaib024 commented Sep 17, 2024

Description

Updated test sdnlb secret id, and secret group
Added allow-listed service id for sdnlb

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

common-go-assets/common-permanent-resources.yaml Outdated Show resolved Hide resolved
common-go-assets/common-permanent-resources.yaml Outdated Show resolved Hide resolved
common-go-assets/common-permanent-resources.yaml Outdated Show resolved Hide resolved
common-go-assets/common-permanent-resources.yaml Outdated Show resolved Hide resolved
common-go-assets/common-permanent-resources.yaml Outdated Show resolved Hide resolved
common-go-assets/common-permanent-resources.yaml Outdated Show resolved Hide resolved
@Soaib024 Soaib024 requested a review from ocofaigh September 17, 2024 11:34
@ocofaigh ocofaigh merged commit 2141da6 into main Sep 17, 2024
1 check passed
@ocofaigh ocofaigh deleted the update-test-sdnlb branch September 17, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants