Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR should run infrastructure tests when common-dev-assets is being updated #1042

Merged
merged 3 commits into from
Sep 24, 2024
Merged

PR should run infrastructure tests when common-dev-assets is being updated #1042

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79c908d
PR should run infrastructure tests when common-dev-assets is being up…
ocofaigh Sep 24, 2024
37555e2
hook
ocofaigh Sep 24, 2024
1ad5ce0
Update run-tests.sh
ocofaigh Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion module-assets/ci/run-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ fi
if [ ${IS_PR} == true ]; then

# Files that should not trigger tests
# NOTE: We are purposely running tests in PRs with 'common-dev-assets' GIT submodule updates since
# terraform version can change, and we will want to run full set of tests if that happens.
declare -a skip_array=(".drawio"
".github/settings.yml"
".github/workflows/ci.yml"
Expand All @@ -80,7 +82,6 @@ if [ ${IS_PR} == true ]; then
"Brewfile"
"CODEOWNERS"
"commitlint.config.js"
"common-dev-assets"
"Makefile"
"renovate.json"
"catalogValidationValues.json.template"
Expand Down