Skip to content

Commit

Permalink
feat: Since Activity Tracker is a deprecated service, the ability to …
Browse files Browse the repository at this point in the history
…pass the CRN of an Activity Tracker instance (`existing_activity_tracker_crn`) in the DA solution to configure the IBM Cloud Object Storage bucket that is used for storing failed events has been removed. Events are now sent according to what is specified in the accounts ATracker Event Routing service configuration. This change will cause an update in place on the COS bucket if using the DA to create one. (#316)

Co-authored-by: Jordan-Williams2 <[email protected]>
  • Loading branch information
jor2 and Jordan-Williams2 authored Oct 16, 2024
1 parent 3171580 commit 85b939d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
3 changes: 1 addition & 2 deletions solutions/standard/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ locals {
module "cos" {
count = local.create_cos_bucket ? 1 : 0
source = "terraform-ibm-modules/cos/ibm"
version = "8.11.15"
version = "8.12.0"
create_cos_instance = var.existing_cos_instance_crn == null ? true : false
create_cos_bucket = local.create_cos_bucket
existing_cos_instance_id = var.existing_cos_instance_crn
Expand All @@ -168,7 +168,6 @@ module "cos" {
kms_key_crn = local.cos_kms_key_crn
monitoring_crn = var.existing_monitoring_crn
retention_enabled = var.retention_enabled
activity_tracker_crn = var.existing_activity_tracker_crn
archive_days = var.archive_days
}

Expand Down
7 changes: 0 additions & 7 deletions solutions/standard/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -268,13 +268,6 @@ variable "management_endpoint_type_for_bucket" {
}
}

variable "existing_activity_tracker_crn" {
type = string
nullable = true
default = null
description = "The CRN of an Activity Tracker instance to configure on the IBM Cloud Object Storage bucket that is used for storing failed events. If no value passed, events are sent to the instance associated to the container's location unless otherwise specified in the Activity Tracker Event Routing service configuration. Ignored if using existing Object Storage bucket."
}

variable "existing_cos_endpoint" {
type = string
description = "The endpoint URL for your bucket region. [Learn more](https://cloud.ibm.com/docs/cloud-object-storage?topic=cloud-object-storage-endpoints). Only required if using an existing bucket with the `existing_cos_bucket_name` variable."
Expand Down

0 comments on commit 85b939d

Please sign in to comment.