-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updated Kibana app endpoint to private #346
base: main
Are you sure you want to change the base?
Conversation
/run pipeline |
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What impact does this have on upgrade? Is it going to tear down anything? Re-deploy kibana? Lets ensure we are deploying kibana as part of DA upgrade test for a start
It is only going to update the endpoint for the Kibana app from |
Also, due to the schematics limitations, we cannot run the upgrade test. |
@ocofaigh , does this come under breaking change? |
@Ak-sky It depends on what actions occur. Will the kibana app be redeployed to to the config error (meaning dashbaord will go down). It seems the upgrade test is not deploying kibana. I think you need to change it so it does so we test that use case |
It does not redeploy Kibana, it is just an update of app endpoint. |
@Ak-sky If |
So @Ak-sky how is somebody supposed to hit the kibana url private endpoint in their browser? We will wan't to document that? Is it even possible to set up a VPN that can access it? |
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. Also dont forget to add new vars to ibm_catalog.json. And use custom dropdown for the endpoint one
Wait for #363 to be merged fist |
3c1df5a
to
7d9b9d8
Compare
/run pipeline |
Description
Git Issue
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
kibana_visibility
variable.kibana_visibility
variable makes it publicly accessible but disables access via IBM Cloud private network, with immediate effect and potential security implications.Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers