test: refactor basic test #567
Conversation
| - Create a new ICD Postgresql database instance. | ||
| - Create a read-only replica of the leader Postgresql database instance. For more info on Read-only Replicas, see [Configuring Read-only Replicas](https://cloud.ibm.com/docs/databases-for-postgresql?topic=databases-for-postgresql-read-only-replicas) | ||
| - Create a read-only replica of the leader database instance. For more info on Read-only Replicas, see [Configuring Read-only Replicas](https://cloud.ibm.com/docs/databases-for-postgresql?topic=databases-for-postgresql-read-only-replicas) |
There was a problem hiding this comment.
A few references to the ICD type (postgres) still remain in the readme for clarity
| name = "${var.prefix}-postgres" | ||
| pg_version = var.pg_version | ||
| name = "${var.prefix}-data-store" | ||
| pg_version = var.db_version |
There was a problem hiding this comment.
This becomes the only line in this file that needs to change from one ICD type to another.
| name = "${var.prefix}-postgres" | ||
| pg_version = var.pg_version | ||
| name = "${var.prefix}-data-store" | ||
| pg_version = var.db_version | ||
| region = var.region | ||
| resource_tags = var.resource_tags | ||
| access_tags = var.access_tags | ||
| member_host_flavor = var.member_host_flavor |
There was a problem hiding this comment.
To support EDB, which does not support multitenant. Default is multitenant.
| description = "Database instance id" | ||
| value = module.database.id |
There was a problem hiding this comment.
All outputs are generic. This file can be used unchanged in every ICD type
| module "replica" { | ||
| source = "../.." | ||
| resource_group_id = module.resource_group.resource_group_id | ||
| name = "${var.prefix}-replica" | ||
| pg_version = var.db_version | ||
| region = var.region | ||
| resource_tags = var.resource_tags | ||
| access_tags = var.access_tags | ||
| member_host_flavor = var.member_host_flavor | ||
| remote_leader_crn = module.database.crn | ||
| depends_on = [time_sleep.wait_time] | ||
| } |
There was a problem hiding this comment.
Moved to a new file. This file can be include in the few ICD types that support replicas and excluded from the others.
| variable "read_only_replicas_count" { | ||
| type = number | ||
| description = "Number of read-only replicas per leader" | ||
| default = 1 | ||
| validation { | ||
| condition = alltrue([ | ||
| var.read_only_replicas_count >= 1, | ||
| var.read_only_replicas_count <= 5 | ||
| ]) | ||
| error_message = "There is a limit of five read-only replicas per leader" | ||
| } | ||
| } |
There was a problem hiding this comment.
Unnecessary complication for an example. Hard code it to 1.
| variable "member_host_flavor" { | ||
| type = string | ||
| description = "Allocated host flavor per member. For more information, see https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/database#host_flavor" | ||
| default = null | ||
| default = "multitenant" |
There was a problem hiding this comment.
Use multitenant for default, will need to override for EDB where it is not supported.
This file can be copied to all ICD types with no changes, but EDB should change the default.
| "db_version": "13", | ||
| "member_host_flavor": "multitenant", |
There was a problem hiding this comment.
The only difference to this test between ICD types is the vars.
Should pinned to minimum supported ICD version.
host flavor could probably be removed here... since it will default to a supported value.
Description
Discussion example of how tests may be refactored, based on basic test.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers