Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose cluster ids #713

Merged
merged 15 commits into from
Mar 13, 2024
Merged

Conversation

Aayush-Abhyarthi
Copy link
Contributor

@Aayush-Abhyarthi Aayush-Abhyarthi commented Feb 16, 2024

Description

[<!--- Expose workload and management cluster IDs. --->]

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aayush-Abhyarthi Can you show proof that outputs worked (screenshot)? And also that they do not output if there is no cluster named "management" or "workload" (if user changes those via override)

@ocofaigh
Copy link
Member

@Aayush-Abhyarthi Seems your logic is wrong somewhere:

│ Error: Invalid index
│ 
│   on ../../outputs.tf line 82, in output "workload_cluster_id":
│   82:   ][0]
│     ├────────────────
│     │ ibm_container_vpc_cluster.cluster is object with no attributes
│     │ var.prefix is "slz-vpc"
│ 
│ The given key does not identify an element in this collection value: the
│ collection has no elements.
╵
╷
│ Error: Invalid index
│ 
│   on ../../outputs.tf line 90, in output "management_cluster_id":
│   90:   ][0]
│     ├────────────────
│     │ ibm_container_vpc_cluster.cluster is object with no attributes
│     │ var.prefix is "slz-vpc"
│ 
│ The given key does not identify an element in this collection value: the
│ collection has no elements.
╵

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

outputs.tf Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

outputs.tf Outdated Show resolved Hide resolved
@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@toddgiguere
Copy link
Contributor

/run pipeline

@Aayush-Abhyarthi
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Member

/run pipeline

@ocofaigh
Copy link
Member

Pipeline failed with [ERROR] Error when creating resource instance: Please contact the Service Provider for this error. [500, Internal Server Error]
Unrelated to changes in this Pr, so re-running..

@ocofaigh
Copy link
Member

/run pipeline

@ocofaigh ocofaigh merged commit cae6de7 into main Mar 13, 2024
2 checks passed
@ocofaigh ocofaigh deleted the expose-workload-management-cluster-id branch March 13, 2024 09:09
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 5.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants