-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose cluster ids #713
Conversation
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aayush-Abhyarthi Can you show proof that outputs worked (screenshot)? And also that they do not output if there is no cluster named "management" or "workload" (if user changes those via override)
@Aayush-Abhyarthi Seems your logic is wrong somewhere:
|
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
Pipeline failed with |
/run pipeline |
🎉 This PR is included in version 5.19.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
[<!--- Expose workload and management cluster IDs. --->]
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers