Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the ability to create Cloud Logs policies in Observability DA #203

Open
ocofaigh opened this issue Oct 29, 2024 · 3 comments
Open
Assignees

Comments

@ocofaigh
Copy link
Member

Support was added in https://github.com/terraform-ibm-modules/terraform-ibm-observability-instances/releases/tag/v3.2.0 and now needs to be exposed in the DA.

TBC:

  • Are we OK to just expose the full complex variable? Is it too complex for a DA? Or maybe its OK to just add a supporting markdown doc? Should it have any default values perhaps using best practises? Something around the TCO Optimizer perhaps?
@maheshwarishikha
Copy link
Member

Discussed this point in Cloud Logs office hours - if there is recommendation for default policy...

Initially they said, make it 100% for Analyze and Alert as default but later they suggested for debug also.
There is no slider for %, it is by rules you have to set.

So as such no recommendation. Team also mentioned that they will up come up with some public doc in some time for app users help. Once this doc is available, then we can link it in our read me.

So I am planning to expose the full complex variable and supporting markdown doc.

@ocofaigh Let me know if you have a different opinion. Thanks.

@maheshwarishikha
Copy link
Member

One more point, if we set default policy and then user adds one on the top of that and if incase, it clashes with default one then first one(default one) will take priority. So user has to delete one and add another.
Hence having a default one will become overhead.

So after our discussion internally, we decided to expose the full complex input type, and create a helper doc.

@maheshwarishikha
Copy link
Member

Currently it is blocked by IBM-Cloud/terraform-provider-ibm#5775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants