Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds the ability to configure cloud logs policies #209

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Conversation

maheshwarishikha
Copy link
Member

@maheshwarishikha maheshwarishikha commented Nov 6, 2024

Description

Add the ability to configure cloud logs policies

Issue: #203
Internal Issue: #11295

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Expose the ability to configure Cloud logs policies

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@maheshwarishikha maheshwarishikha changed the title Adds the ability to configure cloud logs policies feat: Adds the ability to configure cloud logs policies Nov 6, 2024
@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha maheshwarishikha requested review from ocofaigh and iamar7 and removed request for iamar7 November 6, 2024 12:25
Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments

@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

Upgrade test is skipped because added cloud_logs_policy feature in upgrade test. But the main branch DA code does not use the latest observability-instances module which has logs policy feature, Hence it is supposed to fail with the following error:

│ Error: Value for undeclared variable
│ 
│ A variable named "cloud_logs_policies" was assigned on the command line,
│ but the root module does not declare a variable of that name. To use this
│ value, add a "variable" block to the configuration.
╵}

@maheshwarishikha
Copy link
Member Author

Test is failing with the following error:

TestRunExistingResourcesInstances 2024-11-07T05:14:19Z logger.go:66: ╷
Error: gResourcesInstances 2024-11-07T05:14:19Z logger.go:66: │ Error: [ERROR] Error waiting for create resource instance (crn:v1:bluemix:public:logs:us-south:a/abac0df06b644a9cabc6e44f55b3880e:459d9662-90ac-4a84-bc14-36c291684305::) to be succeeded: [ERROR] The resource instance 'crn:v1:bluemix:public:logs:us-south:a/abac0df06b644a9cabc6e44f55b3880e:459d9662-90ac-4a84-bc14-36c291684305::' creation failed: <nil>
TestRunExistingResourcesInstances 2024-11-07T05:14:19Z logger.go:66: │ 
TestRunExistingResourcesInstances 2024-11-07T05:14:19Z logger.go:66: │   with module.observability_instance.module.cloud_logs[0].ibm_resource_instance.cloud_logs,
TestRunExistingResourcesInstances 2024-11-07T05:14:19Z logger.go:66: │   on .terraform/modules/observability_instance/modules/cloud_logs/main.tf line 7, in resource "ibm_resource_instance" "cloud_logs":
TestRunExistingResourcesInstances 2024-11-07T05:14:19Z logger.go:66: │    7: resource "ibm_resource_instance" "cloud_logs" {
TestRunExistingResourcesInstances 2024-11-07T05:14:19Z logger.go:66: │ 
TestRunExistingResourcesInstances 2024-11-07T05:14:19Z logger.go:66: │ ---
TestRunExistingResourcesInstances 2024-11-07T05:14:19Z logger.go:66: │ id: terraform-446cc00a
Error: ExistingResourcesInstances 2024-11-07T05:14:19Z logger.go:66: │ summary: '[ERROR] Error waiting for create resource instance
TestRunExistingResourcesInstances 2024-11-07T05:14:19Z logger.go:66: │ (crn:v1:bluemix:public:logs:us-south:a/abac0df06b644a9cabc6e44f55b3880e:459d9662-90ac-4a84-bc14-36c291684305::)
Error: ExistingResourcesInstances 2024-11-07T05:14:19Z logger.go:66: │   to be succeeded: [ERROR] The resource instance ''crn:v1:bluemix:public:logs:us-south:a/abac0df06b644a9cabc6e44f55b3880e:459d9662-90ac-4a84-bc14-36c291684305::''
TestRunExistingResourcesInstances 2024-11-07T05:14:19Z logger.go:66: │   creation failed: <nil>'
TestRunExistingResourcesInstances 2024-11-07T05:14:19Z logger.go:66: │ severity: error
TestRunExistingResourcesInstances 2024-11-07T05:14:19Z logger.go:66: │ resource: ibm_resource_instance
TestRunExistingResourcesInstances 2024-11-07T05:14:19Z logger.go:66: │ operation: create
TestRunExistingResourcesInstances 2024-11-07T05:14:19Z logger.go:66: │ component:
TestRunExistingResourcesInstances 2024-11-07T05:14:19Z logger.go:66: │   name: github.com/IBM-Cloud/terraform-provider-ibm
TestRunExistingResourcesInstances 2024-11-07T05:14:19Z logger.go:66: │   version: 1.70.0
TestRunExistingResourcesInstances 2024-11-07T05:14:19Z logger.go:66: │ ---
TestRunExistingResourcesInstances 2024-11-07T05:14:19Z logger.go:66: │ 

Re-run did not help. Checking more..

@ocofaigh
Copy link
Member

ocofaigh commented Nov 7, 2024

@maheshwarishikha please check with Cloud Logs team - I think Anam also faced issues

@maheshwarishikha
Copy link
Member Author

@maheshwarishikha please check with Cloud Logs team - I think Anam also faced issues

yes, following it up with them through slack channel and have raised provider issue too.

@maheshwarishikha
Copy link
Member Author

/run pipeline

@maheshwarishikha
Copy link
Member Author

@maheshwarishikha
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit 85dccf8 into main Nov 18, 2024
2 checks passed
@ocofaigh ocofaigh deleted the sm-11295 branch November 18, 2024 10:15
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants