Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add retention rule to the buckets #210

Merged
merged 45 commits into from
Dec 17, 2024
Merged

feat: add retention rule to the buckets #210

merged 45 commits into from
Dec 17, 2024

Conversation

iamar7
Copy link
Member

@iamar7 iamar7 commented Nov 7, 2024

Description

Resolves: Internal#11230

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

This release adds support for adding retention ability to the COS bucket.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@iamar7 iamar7 self-assigned this Nov 8, 2024
@iamar7
Copy link
Member Author

iamar7 commented Nov 14, 2024

/run pipeline

@iamar7 iamar7 marked this pull request as ready for review November 14, 2024 07:48
@iamar7
Copy link
Member Author

iamar7 commented Nov 14, 2024

Upgrade test is failing since it is running on the main branch. Need to skip it
Screenshot 2024-11-14 at 1 18 59 PM

@iamar7
Copy link
Member Author

iamar7 commented Nov 14, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Nov 14, 2024

Failed due to the below error not related to the changes re-running the pipeline

 Error: ---
│ id: terraform-693866e6
│ summary: 'CreateOutgoingWebhookWithContext failed: No authentication information in
│   RequestContext'
│ severity: error
│ resource: ibm_logs_outgoing_webhook
│ operation: create
│ component:
│   name: github.com/IBM-Cloud/terraform-provider-ibm
│   version: 1.70.0
│ ---
│ 
│ 
│   with module.observability_instance.module.cloud_logs[0].ibm_logs_outgoing_webhook.en_integration["0"],
│   on .terraform/modules/observability_instance/modules/cloud_logs/main.tf line 104, in resource "ibm_logs_outgoing_webhook" "en_integration":
│  104: resource "ibm_logs_outgoing_webhook" "en_integration" {
│ 

@iamar7
Copy link
Member Author

iamar7 commented Nov 14, 2024

/run pipeline

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new variables need to be added to ibm_catalog.json

@iamar7
Copy link
Member Author

iamar7 commented Nov 18, 2024

Waiting for the PR-#209 to get merged before updating the branch and re-running the pipeline.

@iamar7
Copy link
Member Author

iamar7 commented Nov 18, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Nov 18, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Dec 13, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Dec 15, 2024

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented Dec 16, 2024

/run pipeline

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

shemau
shemau previously requested changes Dec 16, 2024
@iamar7
Copy link
Member Author

iamar7 commented Dec 16, 2024

/run pipeline

1 similar comment
@iamar7
Copy link
Member Author

iamar7 commented Dec 16, 2024

/run pipeline

@ocofaigh
Copy link
Member

@iamar7 Conflicts need to be resolved

@iamar7
Copy link
Member Author

iamar7 commented Dec 17, 2024

/run pipeline

@ocofaigh ocofaigh merged commit 43524d3 into main Dec 17, 2024
2 checks passed
@ocofaigh ocofaigh deleted the 11230-rr branch December 17, 2024 14:07
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants