Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating provider version for fixing delete agent #76

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Khuzaima05
Copy link
Member

@Khuzaima05 Khuzaima05 commented Oct 21, 2024

Description

updating provider version for fixing delete agent

issue: https://github.ibm.com/orgs/GoldenEye/projects/3/views/1?filterQuery=assignee%3A%40me&pane=issue&itemId=620628

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05 Khuzaima05 changed the title fix: updating provider version for fixing delete agent [WIP] fix: updating provider version for fixing delete agent Oct 21, 2024
Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, there is a note in the main readme which need to be removed

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05 Khuzaima05 changed the title [WIP] fix: updating provider version for fixing delete agent fix: updating provider version for fixing delete agent Oct 23, 2024
@Khuzaima05 Khuzaima05 marked this pull request as ready for review October 23, 2024 16:08
Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idempotent test is failing. It seems to want to destroy and recreate the agent on a subsequent apply. Can you try reproduce locally so we can report to schematics?

@Khuzaima05
Copy link
Member Author

The idempotent test is failing. It seems to want to destroy and recreate the agent on a subsequent apply. Can you try reproduce locally so we can report to schematics?

@ocofaigh

I have tested locally on re-apply:

module.schematics_agent.ibm_schematics_agent.schematics_agent_instance is getting replaced

Screenshot 2024-11-05 at 12 35 21 PM

module.schematics_agent.ibm_schematics_agent_deploy.schematics_agent_deploy is getting replaced

Screenshot 2024-11-05 at 12 35 48 PM

Thats why idempotent test is failing

@ocofaigh
Copy link
Member

ocofaigh commented Nov 7, 2024

@Khuzaima05 please reproduce the issue using the terraform provider directly and enable provider trace logs and create a new provider issue with the exact details to reproduce and logs. Keep the example simple and using provider resources only. Include all info in the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants