ignore tags for kubernetes.io/*

[paulczar]

Kubernetes / OCP will add tags to VPC / Subnets to help with load balancer discovery for services. This ensures those tags are preserved on subsequent terraform runs.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nirarg for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @paulczar. Thanks for your PR.

I'm waiting for a terraform-redhat member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nirarg]

Hi @paulczar ,
Thank you for the contribution
I have also played with this "ignore tags", and I have few questions/doubts here:

1. the tags are added only to the VPC elements, so why do you add this "ignore_tags" to all modules? As I see this, in case user has one module creates the VPC, the ignore should be done only in this specific module
2. You added the "ignore_tags" in provider block. In terraform docs its recommended to have explicit provider declaration only in the main module (see implicit-provider-inheritance), so this solution actually breaks this rule.
   To solve this, I suggest to ignore all tags updates, as described in ignore_changes documentation. That means once the resource was created the tags cannot be updated any more. any thoughts about this?