Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-7904 | fix: refactor name and parameter for classic/hcp #739

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gdbranco
Copy link
Contributor

@gdbranco gdbranco commented Aug 8, 2024

What this PR does / why we need it:

OCM-7904

Change type

  • New feature
  • Bug fix
  • Build
  • CI
  • Documentation
  • Performance
  • Refactor
  • Style
  • Unit tests
  • Subsystem tests

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

@openshift-ci openshift-ci bot requested review from ciaranRoche and vkareh August 8, 2024 10:10
@gdbranco gdbranco marked this pull request as draft August 8, 2024 10:10
Copy link

openshift-ci bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gdbranco. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gdbranco gdbranco changed the title chore: refactor name and parameter for classic/hcp OCM-7904 | fix: refactor name and parameter for classic/hcp Dec 4, 2024
@gdbranco gdbranco marked this pull request as ready for review December 4, 2024 11:34
@gdbranco
Copy link
Contributor Author

gdbranco commented Dec 4, 2024

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant