Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ktor Simple Cache Library #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Scogun
Copy link
Contributor

@Scogun Scogun commented Mar 18, 2024

No description provided.

@terrakok
Copy link
Owner

Hi! I usually don't add fresh libraries (no stars on the github). It should have one real open source project (not sample from the author) with that library at least.
Lets wait a bit 😄

@Scogun
Copy link
Contributor Author

Scogun commented Mar 18, 2024

Hi! It has stars and even supported by JetBrains. But you're right: no any open source project uses it, yet.

@terrakok
Copy link
Owner

terrakok commented Apr 9, 2024

@Scogun
Copy link
Contributor Author

Scogun commented Apr 15, 2024

Hello @terrakok!
The Ktor Simple Cache Plugin is added on official Ktor Project Generator.
Of course, it is published on Maven.
However, it has only 5 stars so far.
Is it enough to merge the PR?

@Scogun Scogun force-pushed the ktor-simple-cache branch from acbb048 to 2805d93 Compare April 15, 2024 17:03
@Scogun
Copy link
Contributor Author

Scogun commented Jun 12, 2024

@terrakok
Copy link
Owner

Good! So, we are waiting more stars now 😉

@Scogun
Copy link
Contributor Author

Scogun commented Jun 12, 2024

Is 10 not enough? 😉

@terrakok
Copy link
Owner

@Scogun
Copy link
Contributor Author

Scogun commented Jun 12, 2024

https://github.com/terrakok/kmp-awesome#contribution-guide

I saw it. As well as:
Screenshot_12-6-2024_10332_github com
Screenshot 2024-06-12 at 10 33 17

But we can wait, of course.

@terrakok
Copy link
Owner

These libraries was added a long time ago when the requirements were lower

@Scogun
Copy link
Contributor Author

Scogun commented Dec 13, 2024

Hello @terrakok,
Is 21 stars still not enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants