Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ivy DI #157

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Ivy DI #157

wants to merge 2 commits into from

Conversation

ILIYANGERMANOV
Copy link

@ILIYANGERMANOV ILIYANGERMANOV commented Dec 15, 2024

Adds https://github.com/Ivy-Apps/di

  1. every suggesion should contain link to any project uses the library (not an author's sample)
    https://github.com/Ivy-Apps/learn

  2. the library is supposed to support Android + iOS targets
    Supports all targets ✅

  3. the library must be published to the MavenCentral
    https://central.sonatype.com/artifact/com.ivy-apps/di

  4. the library should be a popular (github stars ~ 50, at least) 🟡
    Kinda there, it was launched officially and posted publicly a few days so it should reach the 50 mark soon. Currently, it's at 33. For more info see:
    https://github.com/Ivy-Apps/di?tab=readme-ov-file#star-history

@ILIYANGERMANOV
Copy link
Author

@terrakok can you please review? 👀

@terrakok
Copy link
Owner

https://github.com/terrakok/kmp-awesome?tab=readme-ov-file#contribution-guide

@ILIYANGERMANOV
Copy link
Author

https://github.com/terrakok/kmp-awesome?tab=readme-ov-file#contribution-guide

Thanks @terrakok! Updated the PR description with the required info. Can you re-review? 🙏

@ILIYANGERMANOV
Copy link
Author

Btw, you can setup a CONTRIBUTING.MD in the repo so GitHub will automatically prompt folks to read the guidelines before opening PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants