Fix: stardust server #3773
Fix: stardust server #3773
Conversation
Add runtime libraries and other packages needed for misc stardust server usages Signed-off-by: Owen Zimmerman <[email protected]>
|
Are all of these required for the server to function or could some be a |
|
They're needed if you wanna load or do anything in the server beyond very basic functionality. |
| Requires: libxkbcommon libstdc++ libX11 libXfixes libEGL libgbm fontconfig pcre2 | ||
| Requires: libgcc glibc libxcb libglvnd libdrm expat freetype libxml2 libXau libbrotli | ||
| Requires: zlib-ng-compat bzip2-libs libpng harfbuzz libbrotli xz-libs glib2 graphite2 |
There was a problem hiding this comment.
maybe remove things listed in buildreqs already?
There was a problem hiding this comment.
The binary links against all of these, so wouldn't they need to all be runtime deps?
There was a problem hiding this comment.
RPM detects all the shared dependencies needed, which you can check with dnf rq --requires ./path/to/idk.rpm
the Requires: field is specifically for things that are not linked. For example if your binary runs vim inside bash then both vim and bash should be specified as a dependency since they are not linked.
Remember last time we tested stardust with Nova? Well I suspect everything has already been specified correctly by rpm automatically since it ran "fine"
If you see something like "undefined symbol" or "symbol lookup error" then 1. there's something wrong with the linking process and/or 2. you might need to specify some extra stuff in Requires
You may choose to continue specifying all the runtime dependencies but it probably does nothing and you increase maintenance burden, since if a newer version doesn't need a dep anymore you'll need to manually remove the Requires
There was a problem hiding this comment.
Ahh, I see thank you. I'll do some more testing and talk to Nova.
That is fair, but generally things not needed for the program itself to run should be weak deps so people can exclude the packages they may not want for any reason (not using a specific feature, etc.) |
Theoretically they should all be needed for full functionality. |
Add runtime libraries and other packages needed for misc stardust server usages