-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: add format flag to support PNG output to stdout #2257
Conversation
closes #2214 |
Hi @alixander this is my first PR for D2, please let me know if I’ve missed anything! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your first contribution! Looks mostly good, just some minor comments
You'll need to update the man page too please: https://github.com/terrastruct/d2/blob/master/ci/release/template/man/d2.1
and add a line to next.md as a new feature: https://github.com/terrastruct/d2/blob/master/ci/release/changelogs/next.md
Hi @alixander, Thank you for your detailed review and guidance! I've completed the requested updates. 😊 |
@Maricaya this looks good to me, thanks for addressing the comments. I'm not sure what happened but only one of your commits is signed, would you mind fixing that? Ready to merge after |
Add --format flag to enable PNG output to stdout, allowing users to pipe D2 diagram output in PNG format to other tools.
Changes:
Example usage:
Test: ./make.sh test