Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: semantic markup #130

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Conversation

dev-nicolaos
Copy link
Contributor

Changes

Fixes several spots in the docs where the <blockquote> element was being incorrectly used to apply styling. Along with #127 , this change fixes #124

There was also one spot on the getting started page where a closing tag for an <ol> got moved way down the page, breaking the page's flow. This PR also fixes that issue by moving the closing tag back up to the end of the list.

How to Review

Build the docs and this branch and observe that the styling of the affected docs looks identical. Use dev tools to inspect the underlying markup and observe that the content changed now uses the correct semantics.

Fixing the issue with the closing <ol> caused prettier to change the indentation on much of the getting started page. It may be easier to review if you turn off showing white-space changes.

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

⚠️ No Changeset found

Latest commit: 08bc1ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@drwpow drwpow merged commit beaf9bc into terrazzoapp:main Oct 23, 2023
5 checks passed
@dev-nicolaos dev-nicolaos deleted the docs-semantic-markup branch October 23, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs blockquotes accessiblitly concerns
2 participants