Add best practices for token types #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploying with
|
| Latest commit: |
d28f027
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f86ba151.cobalt-ui.pages.dev |
| Branch Preview URL: | https://plugin-docs.cobalt-ui.pages.dev |
drwpow
force-pushed
the
plugin-docs
branch
3 times, most recently
from
89769a2
to
e951221
Compare
drwpow
commented
Jan 16, 2024
| "test:plugin-sass": "cd packages/plugin-sass && pnpm run test", | ||
| "test:plugin-tw": "cd packages/plugin-tailwind && pnpm run test", | ||
| "test:utils": "cd packages/utils && pnpm run test", | ||
| "test": "pnpm run -r --if-present --aggregate-output --parallel test", |
There was a problem hiding this comment.
Note to literally no one but myself: --parallel on the top level is a good idea. Nested --parallels is a horrible idea (i.e. don’t use within any packages).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #180. Adds some Tips & recommendations sections to different token pages, to help people writing their own plugins & custom transformers.
Also as a chore, removes
npm-run-allin favor of a simplerpnpm runworkflow.How to Review
pnpm runchange will probably break Cloudflare Pages; ’sok