Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing improvements #231

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Parsing improvements #231

merged 4 commits into from
Mar 26, 2024

Conversation

drwpow
Copy link
Collaborator

@drwpow drwpow commented Mar 26, 2024

Changes

  • Adds wayy better JSON parsing errors that shows exact line & code output on error
  • Adds support for JSON & YAML parsing in @cobalt-ui/core
  • Minor cleanup
  • Swaps js-yaml for yaml (which I’m sad about, because js-yaml is faster, but it hasn’t gotten an update in years and yaml is actively-developed)

How to Review

  • Tests added; tests should pass

Copy link

changeset-bot bot commented Mar 26, 2024

🦋 Changeset detected

Latest commit: 8f118b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@cobalt-ui/core Minor
@cobalt-ui/cli Minor
@cobalt-ui/lint-a11y Major
@cobalt-ui/plugin-css Major
@cobalt-ui/plugin-js Major
@cobalt-ui/plugin-sass Major
@cobalt-ui/plugin-tailwind Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

cloudflare-workers-and-pages bot commented Mar 26, 2024

Deploying cobalt-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: ddd758c
Status: ✅  Deploy successful!
Preview URL: https://094d8d40.cobalt-ui.pages.dev
Branch Preview URL: https://parsing-improvements.cobalt-ui.pages.dev

View logs

@drwpow drwpow force-pushed the parsing-improvements branch from 3ea0e8a to 18d98b3 Compare March 26, 2024 15:18
@drwpow drwpow force-pushed the parsing-improvements branch 3 times, most recently from f3ac824 to ddd758c Compare March 26, 2024 15:45
@drwpow drwpow force-pushed the parsing-improvements branch from ddd758c to 8f118b1 Compare March 26, 2024 15:53
@drwpow drwpow merged commit 6bd9978 into main Mar 26, 2024
9 checks passed
@drwpow drwpow deleted the parsing-improvements branch March 26, 2024 16:07
@github-actions github-actions bot mentioned this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant