Implement code size count from makefile. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit uses the portable POSIX solution for counting the size of the output library (.a), namely wc -c. The output is specifically produced in the successful "end of make" message. Alternatively, one can now explicitly "make codesize". We should specifically note that: code size will depend on target architecture (x86_64 has 8-byte pointers, for example) and does not account for the extraction of the various elf-objects. That is, this code currently gives an upper bound estimate of the size INCLUDING **ELF** metadata and symbols for each and every file in the archive. A release image would strip all this information.
diagprov
added
C-Enhancement
|
@veorq this is a pretty minor change. If you like it, feel free to hit merge directly. I will seek to improve this, but this gives us an easy way to estimate the code size when talking to customers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uses the portable POSIX solution for counting the size of
the output library (.a), namely wc -c.
The output is specifically produced in the successful "end of make"
message.
Alternatively, one can now explicitly "make codesize".
We should specifically note that: code size will depend on target
architecture (x86_64 has 8-byte pointers, for example) and does not
account for the extraction of the various elf-objects. That is, this
code currently gives an upper bound estimate of the size INCLUDING ELF
metadata and symbols for each and every file in the archive. A release
image would strip all this information.